search

webtorrent / instant.io

🚀 Streaming file transfer over WebTorrent (torrents on the web)
https://instant.io
MIT License
3.46k stars 438 forks source link

Show QR code #94

Open ghost opened 8 years ago

ghost commented 8 years ago

Show a QR code for the different links so that mobile devices can become peers without users having to type in the URL.

joshterrill commented 8 years ago

I can give this a go if it's wanted.

ghost commented 8 years ago

I only use instant.io occasionally, so don't feel obliged to do this for my sake. I do think that this feature would be very handy though.

feross commented 8 years ago

@joshterrill Yeah, that would be cool to try. But are there any good QR reading libraries in pure javascript? I've seen tons of QR code generators, but only a few that can take grainy images from a webcam and parse the QR codes out of them.

joshterrill commented 8 years ago

I'll look around and post what I find before I really start digging into it.

xxxorg commented 8 years ago

@feross I found just https://github.com/LazarSoft/jsqrcode, do you know any other qr reading in js?

xxxorg commented 8 years ago

Would you accept PR just for the qr code generation (not the reading)?

joshterrill commented 8 years ago

@xxxorg I don't think we need it to read... I think it's just QR code generation so that a mobile app who has a reader can scan it. Am I right?

feross commented 8 years ago

I would accept a PR just for generation for now. We can figure out reading later.

On Fri, 11 Mar 2016 at 15:18 Joshua Terrill notifications@github.com wrote:

@xxxorg https://github.com/xxxorg I don't think we need it to read... I think it's just QR code generation so that a mobile app who has a reader can scan it. Am I right?

— Reply to this email directly or view it on GitHub https://github.com/feross/instant.io/issues/94#issuecomment-195599483.

nodiscc commented 8 years ago

I can recommend http://neocotic.com/qr.js/ for QR generation which I have been using for years in a web application.

joshterrill commented 8 years ago

I just wrote this yesterday but forgot to commit it. I'll do it later today.

rugk commented 8 years ago

As for qrcode generation there is also https://larsjung.de/kjua/. It works without jQuery and is very powerful. (alternatively this works with jQuery)

aswinmohanme commented 6 years ago

@feross can you look into this ?

I know a dev like you would be pretty busy, but this feature would solve the issue of sharying a file with a phone easy peasy.

joshterrill commented 6 years ago

I apologize for letting this just stay open like this. I've been pretty swamped at work. If the suggestion @rugk has looks good to everyone I can try to implement it over the 4th of July break this week. @feross since that is a different library and the other pull request is pretty old, should we close the other one out and start a new one? Or should I pull the existing one down and edit it?

joshterrill commented 6 years ago

@feross I just finished writing the code... not sure how you want me to go about pushing it though. Should I pull down my other PR and modify that? Or use a new one since I'm using a different library than before?

joshterrill commented 6 years ago

There were enough differences in the existing code base and what was in that old PR that I figured I could just create a new PR. If this isn't what you want to do, just let me know. I've created https://github.com/webtorrent/instant.io/pull/176 using the library @rugk suggested.

ThelloD commented 3 years ago

Any update regarding the implementation status of QR codes? Feature request was created 5 years ago and pull request 1.5 years ago, so it's a bit sad that this wasn't added, yet.

pojntfx commented 3 years ago

I would also really appreciate this feature. https://webwormhole.io/ is fantastic in terms of this; if one wants to, for example, transfer a file from their desktop to their phone, this would be greatly appreciated.