webtorrent / load-ip-set

download and parse ip-set (blocklist) files
MIT License
22 stars 11 forks source link

Normalized ipset format is not parsed correctly? #4

Closed jotadepicas closed 8 years ago

jotadepicas commented 8 years ago

Hi, I started using load-ip-set but it seems that if your ipset file is just a list of IP addresses, one per line (and not in the form "description:fromIP-toIP", just one IP per line, no description, no from-to range, etc) it is not recognized by your regex.

I am using https://github.com/firehol/blocklist-ipsets and for example, zeus_badips is in this format.

Am I doing something wrong or is this expected? If I cannot parse files with just IPs on them, I would have to go directly to ip-set like you did, but I would rather use your wrapper module instead.

thanks!

jotadepicas commented 8 years ago

I forked your repo and updated the regex to support with IP ranges and single IPs, with or without a string description. Updated the corresponding tests as well. You can give it a look at: https://github.com/jotadepicas/load-ip-set/commit/a321184b9cf3bb668b796dd65be81f1e563bf6b5