jimmywarting
commented
6 years ago Also experienced a few crashes after i update. But wasn't sure what the cause was.
Closed ukserversltd closed 5 years ago
jimmywarting
commented
6 years ago Also experienced a few crashes after i update. But wasn't sure what the cause was.
ukserversltd
commented
6 years ago Yea I have tried a few ways, like pausing before going back and still the same... when I have time, which being a web developer at the moment don't have much for playing but will download source and see if I can debug but glad I am not the only person getting the issue as well.
I am still using the application of course as it's a really good torrent app, nothing better in my opinion so i just wait for it to crash and then open it back up but thought should raise the bug anyhow.
Was / and not sure if development is still going on with WebTorrent as had it installed around a year now which was version 0.20.0 and noticed that is still the latest release, hence why thought might have been out of date and checked out if was a new version but wasn't.... hence the raising of this bug lol
ukserversltd
commented
6 years ago Not sure if this helps, done a local build and when doing npm run watch this was the log
[nodemon] 1.14.11
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `npm run start`
> webtorrent-desktop@0.20.0 start /Users/james/Websites/Clients/WebTorrent/webtorrent-desktop
> npm run build && electron .
> webtorrent-desktop@0.20.0 build /Users/james/Websites/Clients/WebTorrent/webtorrent-desktop
> buble src --output build
2018-10-03 23:11:13.295 Electron[11099:2898851] *** WARNING: Textured window <AtomNSWindow: 0x7fadb5592260> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.
init: 1587.941ms
[nodemon] clean exit - waiting for changes before restart
mathiasvr
commented
6 years ago The warning is mentioned in a bunch electron issues. It doesn't appear to have been completely fixed yet. However, this should not cause a crash.
It would be helpful, if you could checkout the update-electron branch and try building that, to see if that solves the problem.
ukserversltd
commented
6 years ago Will give it a try and let you know
ukserversltd
commented
6 years ago So switched to that branch, done a new npm install and then a npm run watch but same thing with crashing. Is there anyway to monitor in the console to try and catch it breaking?
Below is what I am getting in the console after the crash, and also git status showing the branch: Added console log and also below that the macos log
And if helpful here is the crash report from my macbook:
mathiasvr
commented
6 years ago Thanks for looking into this.
I think this could be related to https://github.com/electron/electron/issues/14837.
We unregister media keys on the onPlayerClose event.
leohubert
commented
6 years ago Temporarily you can give Accessibility access for WebTorrent in your settings
mathiasvr
commented
6 years ago @MrDarkSkil I don't know much about Mojave, does the app have to request accessibility access before the user can allow it? And does that solve this issue?
We could also temporarily disable media keys in Mojave.
Hopefully, someone with Mojave can make a pull request.
leohubert
commented
5 years ago Now Mojave does as on the iPhone it asks the user when an application want to access to an system functionality, in this case with WebTorrent it asks to be able control the mac (for the management of keyboard keybinding i think), if the user refuse, electron can't register and unregister keyboard keybinding and produce an crash.
So if you give WebTorrent the Accessibility access, electron can register a keyboard events and will not crash.
sysradium
commented
5 years ago @MrDarkSkil thanks a lot. Solved the problem for me. However I hope this can be fixed without giving the app these permissions.
conorseed
commented
5 years ago Confirmed I had the same issue as OP. To stop the crashing here's what I did:
ErikSwan
commented
5 years ago This workaround (giving WebTorrent Accessibility permissions to prevent the crash) should be made clear in an FAQ or in a pop-up message within the app before making the call to request accessibility permissions and show the native OS dialog.
Since the Accessibility permissions can be used to log keystrokes and do other nasty things, getting asked for these permissions from a torrent client without any kind of explanation is pretty sketch. I had to do some Googling to try to understand why WebTorrent was requesting this, which lead me here.
Please make this more clear. If you are requesting elevated permissions from the user, always explain why you need them.
dsernst
commented
5 years ago I still see this crash every time when trying to play in-app, if OS X Accessibility controls denied. 😵
The upstream issue in electron appears fixed by https://github.com/electron/electron/pull/16262, landed in electron@^4.0.1.
PR to upgrade electron: https://github.com/webtorrent/webtorrent-desktop/pull/1523.
feross
commented
5 years ago I'm going to close this issue as the problem is fixed on master. You can follow the progress to release a new version of WebTorrent Desktop to all users in this issue here: #1674 We're very close! ❤️
What version of WebTorrent Desktop? (See the 'About WebTorrent' menu) Version 0.20.0 (0.99.3)
What operating system and version? MacOS Mojave (10.14)
What did you do? When adding torrent it crashes, when clicking back to torrent list it also crashes
What did you expect to happen? Not to crash
What actually happened? It Crashed