search

webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.69k stars 1k forks source link

Enable uTP protocol #1854

Closed karloluis closed 7 months ago

karloluis commented 4 years ago

What version of WebTorrent Desktop are you using? v0.23.0

What operating system and version? Mac OS

What happened? A magnet link did not load as many peers/seeds as it did using another client.

A large torrent was taking long to DL and after a while I tried the same with uTor to see if there was any difference. To my surprise uTor did eventually find more peers/seeds than WebTor did. Even having the two run concurrently didn't seem to phase WebTor client.

Force Quit and pause/resume the torrent to no avail.

What did you expect to happen? Discovering peers/seeds effectively.

Are you willing to submit a pull request to fix this bug? Not at this time.

dsernst commented 4 years ago

Is this easy to reproduce?

karloluis commented 4 years ago

I've tried with some 2019 torrent files and happens fairly consistent with low peer/seed connections.

dsernst commented 4 years ago

Confirming that I am seeing this as well.

Had a download taking unusually long in Webtorrent Desktop... first time I recall running into this issue. For some reason the download effectively stopped, after it had successfully downloaded 4gb (7%). Even though it said 38 peers were still available.

Webtorrent Desktop:

webtorrent

I tried loading up the same magnet link in uTorrent and it pretty quickly was able to get download speeds up to 10MB/s again.

uTorrent:

utorrent

Same torrent, same internet connection. This is on a fresh install of Windows 10 w/ Webtorrent Desktop 0.24.0.

Note one distinction from @karloluis's report: I am not having any trouble finding peers (Webtorrent actually found 38 vs only 34 for uTorrent), just not seeing good download speeds.

As I said this is somewhat unusual, I can't recall running into this issue with Webtorrent previously, despite years of usage.

dsernst commented 3 years ago

@hicom150's µTP PR https://github.com/webtorrent/webtorrent/pull/1923 may address this! 🤞

feross commented 3 years ago

@dsernst Yeah, perhaps some other popular client has been updated to prefer uTP? Without digging into the details of what's happening at the lower layers, it's hard to say.

I'll repurpose this issue for enabling uTP in WebTorrent Desktop, since it needs an explicit utp: true flag to be set in order to work.

Does someone want to add this flag, test it out, and then send a PR?

hicom150 commented 3 years ago

I've created #1900 to enable uTP 👍