webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.67k stars 1k forks source link

refactor: replace deprecated String.prototype.substr() #2173

Closed CommanderRoot closed 2 years ago

CommanderRoot commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] commented 2 years ago

🎉 Congrats on getting your first pull request landed!