webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.67k stars 1k forks source link

macOS: Create Universal application #2190

Closed Teutates closed 1 year ago

Teutates commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [ X ] Other, please explain: Adds arm64 arch to macOS build

What changes did you make? (Give an overview)

Add arm64 arch to macOS build to create a universal Intel/Apple Silicon app

Which issue (if any) does this pull request address?

1907

Is there anything you'd like reviewers to focus on?

N/A

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

github-actions[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

fishcharlie commented 2 years ago

Is this still relevant?

Yes.

If so, what is blocking it?

@DiegoRBaquero is assigned and hasn't had any activity on this PR since April 5th. So @DiegoRBaquero is currently blocking this PR.

Is there anything you can do to help move it forward?

Hopefully tagging @DiegoRBaquero will help move this forward 😉.


Really want to see this!

DiegoRBaquero commented 2 years ago

Can you please resolve the conflicts?

fishcharlie commented 2 years ago

@DiegoRBaquero Not sure I'm gonna be able to do that since I'm not the PR author.

@Teutates can you resolve the merge conflicts?

Teutates commented 2 years ago

@fishcharlie @DiegoRBaquero Does this do the trick?

treeshateorcs commented 2 years ago

works fine here, i have successfully built webtorrent-desktop for arm64 macos

Teutates commented 2 years ago

Bumping @DiegoRBaquero

tie commented 1 year ago

If anyone is willing to run code from a random dude on the Internet until this PR gets merged and released, I’ve built the package with refs/pull/2190/merge checked out.

https://transfer.sh/xMRjmg/WebTorrent.zip

@DiegoRBaquero @Teutates is there anything blocking this PR?

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

fishcharlie commented 1 year ago

Yes. It's still relevant. As @Teutates mentioned above: Bumping @DiegoRBaquero

ivan-zakharchuk commented 1 year ago

why this wasn't merged since the Autumn?

Teutates commented 1 year ago

@DiegoRBaquero latest merge conflicts removed.

fishcharlie commented 1 year ago

@DiegoRBaquero this PR has been open for over a year now. Any status updates?

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

tie commented 1 year ago

Yes, this is still relevant. cc @DiegoRBaquero

farribeiro commented 1 year ago

I'm considering this project is no longer relevant to webtorrent, need to manually update a lot of dependencies plus webtorrent 2.x doesn't work with this client. apart from electron that is very Old

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

fishcharlie commented 10 months ago

Really disappointing that this was closed. @DiegoRBaquero can we get this reopened and merged?