Closed Acelya-9028 closed 9 months ago
🙌 Thanks for opening this pull request! You're awesome.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
Yes still relevant
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
YES!
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
YES!
the bot keeps marking this issue as stale, but it would nice to have a fix.
https://github.com/webtorrent/webtorrent-desktop/issues/2101
This project is dead af sorry :(
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:
What changes did you make? (Give an overview)
I split the string returned by the
vlc-command
package to separate the command from its arguments.https://github.com/feross/vlc-command/blob/master/index.js#L64
Which issue (if any) does this pull request address?
The flatpack version of VLC does not work because the
vlc-command
package returnflatpak run org.videolan.VLC
and this is interpreted as the whole command instead of the command with its arguments.https://github.com/webtorrent/webtorrent-desktop/issues/2094
Not exactly the same but this trick is not needed in this case now.
echo -e '#!/bin/sh\n\nflatpak run org.videolan.VLC $@' > ~/spawn-vlc.sh