webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.69k stars 1k forks source link

fix: use the flatpack version of VLC #2292

Closed Acelya-9028 closed 9 months ago

Acelya-9028 commented 1 year ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

I split the string returned by the vlc-command package to separate the command from its arguments.

https://github.com/feross/vlc-command/blob/master/index.js#L64

Which issue (if any) does this pull request address?

The flatpack version of VLC does not work because the vlc-command package return flatpak run org.videolan.VLC and this is interpreted as the whole command instead of the command with its arguments.

https://github.com/webtorrent/webtorrent-desktop/issues/2094

Not exactly the same but this trick is not needed in this case now.

echo -e '#!/bin/sh\n\nflatpak run org.videolan.VLC $@' > ~/spawn-vlc.sh

welcome[bot] commented 1 year ago

🙌 Thanks for opening this pull request! You're awesome.

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

Acelya-9028 commented 1 year ago

Yes still relevant

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

Acelya-9028 commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

YES!

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

Acelya-9028 commented 1 year ago

YES!

r14c commented 12 months ago

the bot keeps marking this issue as stale, but it would nice to have a fix.

https://github.com/webtorrent/webtorrent-desktop/issues/2101

Acelya-9028 commented 12 months ago

This project is dead af sorry :(

github-actions[bot] commented 10 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?