search

webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.62k stars 998 forks source link

Enable builds on every push, add macos arm builds #2350

Closed Paxa closed 9 months ago

Paxa commented 1 year ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [v] Other, please explain:

What changes did you make? (Give an overview)

Which issue (if any) does this pull request address?

https://github.com/webtorrent/webtorrent-desktop/issues/2309#issuecomment-1576733167

Is there anything you'd like reviewers to focus on?

  1. What will be better to make separate x86 and arm builds or use universal type? (https://github.com/electron/universal)

Example of download page https://nightly.link/Paxa/webtorrent-desktop/workflows/package/dev-builds (zips are quite big because one job produce mulple files) To make nightly.link it will require to authorize this app in github oauth

I've checked mac package, it contain .zip and .dmg files, will it be ok to keep only .dmg ?

Screenshot 2023-06-07 at 04 35 34
welcome[bot] commented 1 year ago

🙌 Thanks for opening this pull request! You're awesome.

socket-security[bot] commented 1 year ago

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives^1 Size Publisher
electron-packager ⬆️ 15.5.2...17.1.1 None +8/-7 880 kB georgexu99
dsernst commented 1 year ago

Love to see this. Does this PR produce a binary we can test?

Paxa commented 1 year ago

@dsernst It does, you can see in last pipeline https://github.com/Paxa/webtorrent-desktop/actions/runs/5193592670 (artifacts section below) or on here https://nightly.link/Paxa/webtorrent-desktop/workflows/package/dev-builds

github-actions[bot] commented 10 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?