webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.72k stars 1k forks source link

Embed VLC #938

Closed bitnom closed 1 year ago

bitnom commented 8 years ago

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)

What operating system and version? 0.16.0 (0.97.1) (64 bit) What did you do? Played video of various formats What did you expect to happen? Playback within the application even if VLC is required. What actually happened? VLC is launched independent of webtorrent in a new window.

There's another player called Powder Player which beautifully embeds VLC. It's far better a solution to do that, espcially in support of people who would embed this streamer/player in their application. It can't be that hard. I once managed a software project where VLC was embedded in a Java applet and one of our devs had that done in a day.

This if of course a feature request. I'd like to include this streamer in my upcoming application but this is what's holding me back. Thanks and keep up the good work.

feross commented 8 years ago

embeds VLC. It's far better a solution to do that

This is an approach that @dcposch investigated a while ago. I think he ran into errors and segfaults when WebChimera.js was used to embed VLC. Maybe we can give it another go since it's been a few months? This is one of the last features we need before 1.0!

I'd like to include this streamer in my upcoming application

Can you elaborate? How do you plan to embed WebTorrent Desktop into your app? Do you mean you plan to use WebTorrent, the library?

bmathews commented 7 years ago

One problem I had using WebChimera in electron was the rendering performance and cpu usage, due to transferring each frame to JS and then drawing to a canvas using JS.

Today I stumbled upon this, which uses chromium's pepper api, which gives a native C plugin raw access to OpenGL rendering. This project uses https://mpv.io for this:

https://github.com/Kagami/boram/blob/c22b3b6cb48bfe3678ba9f63c6249cce295c290c/src/mpv/index.js#L136 https://github.com/Kagami/boram/blob/master/src/mpv/interop.cc

Edit: This could presumably be done with libvlc, too?

marcus-sa commented 7 years ago

Any updates on this?

ryndshn commented 7 years ago

+1

asolopovas commented 5 years ago

+1

marcus-sa commented 5 years ago

I did get started on a project which uses libvlcpp, but actually never really got further (more important stuff to do)

https://github.com/venobo/cerberus

github-actions[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?