search

webtorrent / webtorrent-desktop

❤️ Streaming torrent app for Mac, Windows, and Linux
https://webtorrent.io/desktop
MIT License
9.74k stars 1.01k forks source link

Remove torrent immediately, but allow Undo #970

Open DiegoRBaquero opened 8 years ago

DiegoRBaquero commented 8 years ago

I'd like to make a feature request.

If you are removing many torrents from the client you have to click on the remove button in the confirmation dialog each time. It would be great if I could check a checkbox that said "Do not show this again" and just click on the X that removes the torrents.

What do you guys think?

mathiasvr commented 8 years ago

I actually included such a checkbox in my initial PR for the confirmation modals, but it seemed more clean not to have it. Another way to solve this is by having a preference as suggested in #853.

feross commented 8 years ago

The cleanest way to solve this, IMO, is to just remove it immediately, but to show a little "Undo" hover card at the bottom of the view for 10 seconds after deleting a torrent.

The thinking is: Do what the user wants immediately. Treat the user like an adult who knows what they're doing, so don't ask for confirmation constantly. Yet, provide a means for them to recover from mistakes.

Here's an example of how Inbox (by Google) implements this, in the bottom-left corner of the app.

screen shot 2016-09-26 at 11 19 26 pm
DiegoRBaquero commented 8 years ago

@feross Damn, I love that idea. Would definitely leave preferences to be important stuff and never bother the user.

feross commented 8 years ago

@DiegoRBaquero Yeah, some things need preferences, but I think the right instinct is to push back and consider other solutions first. Once you add a preference it's really hard to remove. Let's try really hard to do the right thing, and use preferences as a last resort. 👍

mathiasvr commented 8 years ago

@feross I like this idea, but I wonder if it would be enough to just use undo/cmd+z then?

feross commented 8 years ago

Hm, I think that a keyboard shortcut alone works as a first attempt. But I would want to play around with the little notification message at the bottom and see if that's helpful to the user. Maybe it's too much for a desktop app, but we should try it IMO.

Btw, for the "delete file data" option in the right click menu, we probably still want the confirmation dialog since that's not possible to reverse, and it's a less commonly used than just clicking the 'X'.

github-actions[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?