search

webtorrent / webtorrent-hybrid

WebTorrent (with WebRTC support in Node.js)
https://webtorrent.io
MIT License
519 stars 98 forks source link

fix: webrtc import #143

Closed gdborton closed 2 years ago

gdborton commented 3 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) The recent esm update changed the structure of the resulting wrtc object, this breaks web peers in webtorrent-hybrid.

I found that this change makes simple-peer fail on this line: https://github.com/feross/simple-peer/blob/master/index.js#L101

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

welcome[bot] commented 3 years ago

🙌 Thanks for opening this pull request! You're awesome.

DiegoRBaquero commented 2 years ago

With which error does it fail? wrtc does not have a default export

welcome[bot] commented 2 years ago

🎉 Congrats on getting your first pull request landed!

webtorrent-bot commented 2 years ago

:tada: This PR is included in version 5.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: