Closed ttytm closed 4 months ago
Brilliant! I prefer this approach too, much easier to maintain. Thank you @ttytm 👍
Nice, then we would just need to fix the failing windows build.
Since direct interop is theoretically possible with Go, we should use it. Eventually it will make things simpler for us and for the users. It cries out for problems managing a bootstrap step for different versions of a module in the GOPATH on different platforms :D.
We have wrappers where directly interop would not be possible afaik, like odin-webui. But since the bootstrap is only required locally there, is is less complicated, and manageable.
When we can achieve direct interop with WebUI's C code, I think the best solution is to add it as a submodule.
This will have the same advantage as a setup script that bootstraps the WebUI build - not needing to add binary files that would consistently need to be updated. At the same time, it would be simpler to manage, as the Go wrapper either needs to be set-up in the GoPath or locally. With a submodule, this step becomes obsolete. Especially for setting up different future versions or for cases where going backwards in the repository history, this can be helpful.
There are only some conflicts remaining on Windows that need to be resolved.