webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and modern web technologies in the frontend, all in a lightweight portable library.
https://webui.me
MIT License
2.9k stars 164 forks source link

Fix `mkdir dist` in build step on windows #172

Closed ttytm closed 1 year ago

ttytm commented 1 year ago

I encounter the same issue with the dist dir creation in the Makefile when using the library in the V wrapper CI. That the current command to conditionally create a directory on Windows is not working reliable, looks like a version related issue.

The current command @-$(shell if not exist $(BUILD_DIR) mkdir -p "$(BUILD_DIR)" >nul 2>&1) wanted to omit the ignored error message mingw32-make: [Makefile:77: --setup] Error 1 (ignored) if the dist directory already existed. With the newly used command this is also possible and it has better compatibility.