search

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and modern web technologies in the frontend, all in a lightweight portable library.
https://webui.me
MIT License
2.97k stars 173 forks source link

Create mac archive before uploading #255

Closed ttytm closed 11 months ago

ttytm commented 12 months ago

Reverts the recent PR, that had no effect on the outcome.

Creates the compressed archive before uploading as an attempt to solve an issue for macos-x64 where the uploaded release archive seems to get corrupted. In case the upload action has an effect on the later archived files this should prevent it.

ttytm commented 12 months ago

Those are pretty blind shots, don't like to approach it that way. We can try this one but if it also doesn't work, I rather try to get my hands on an old mac and check if the issue is reproducible. Then test creating releases on a repo fork and push things when they appear to be a real fix for the issue.

For now, the .dylib for macOS x64 archives downloaded from nightly releases appear to be broken.

hassandraga commented 12 months ago

While I'm re-testing the security side of the .dylib file, we can check the GNUSparseFile.0 issue meanwhile.

ttytm commented 12 months ago

:+1: Okay, I'm also removing the executable bit, to reduce the chance of mac flagging it as insecure when uncompromising. The bit is also removed automatically when the artifact is uploaded in the actions - the downloads that work.

It's visible on the screenshot I posted in the related issue, no x.

Screenshot_20231013_182157

Maybe one of the changes here works. We can try it.

we can check the GNUSparseFile.0 issue meanwhile.

Is also something I cannot reproduce. So currently I have to delegate fixing this.