search

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and modern web technologies in the frontend, all in a lightweight portable library.
https://webui.me
MIT License
2.96k stars 172 forks source link

fix: add linux dynamic library "lib" prefix #306

Open iacore opened 8 months ago

AlbertShown commented 8 months ago

LGTM. All wrappers that use a downloader script/code should update the lib name for Linux after merging this PR.

ttytm commented 4 months ago

In case this change is made, wouldn't it be most consistent make a general update, instead just the dyn out on linux?

https://github.com/webui-dev/webui/blob/9f120e974fcb333bbc749790ea233c15e5494513/GNUmakefile#L5

iacore commented 4 months ago

In case this change is made, wouldn't it be most consistent make a general update, instead just the dyn out on linux?

https://github.com/webui-dev/webui/blob/9f120e974fcb333bbc749790ea233c15e5494513/GNUmakefile#L5

That is not what this is about. Only the Linux .so output is broken, I think.

Also, did someone forget to merge this? :?

ttytm commented 4 months ago

That is not what this is about. Only the Linux .so output is broken, I think.

Also, did someone forget to merge this? :?

Well it is about that. And I wanted to resolves this question about making a more general update to ensure consistency before merging the PR...

E.g. with your current changes it will stay without lib on macos. Ref.: https://github.com/webui-dev/webui/blob/b3c8f78271c6f33664b5891d6edd61d4574b21a2/GNUmakefile#L58-L61

ttytm commented 4 months ago

I don't think it was broken either, it was just the name chosen so far. We can look into platform naming conventions get to the best possible state when making a breaking change like this.