zig msvc toolchain support

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and HTML5 in the frontend, all in a lightweight portable lib.

https://webui.me

MIT License

2.36k stars 144 forks source link

zig msvc toolchain support #322

Closed jinzhongjia closed 3 months ago

jinzhongjia commented 5 months ago

Add a macro definition and use _strdup instead of strdup under msvc

SpikeHD commented 3 months ago

While seemingly unrelated, this PR is required for https://github.com/webui-dev/rust-webui/pull/3 to work. Would love to see this merged!

AlbertShown commented 3 months ago

Looks good, thank you 👍

jinzhongjia commented 3 months ago

Hey, @neroist @hassandraga hasn't appeared in a long time, maybe we should merge these PRs for now?

jinzhongjia commented 3 months ago

Now this PR contains the API fix of zig nightly

AlbertShown commented 3 months ago

Any PR that has changes to Zig files only, you can marge it right away as you are the main Zig maintainer. This PR has also updated webui.h, but only adding a define which does not require all wrappers to be updated, so all good.

jinzhongjia commented 3 months ago

Thx!

AlbertShown commented 3 months ago

Thank you @jinzhongjia 👍