search

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and HTML5 in the frontend, all in a lightweight portable lib.
https://webui.me
MIT License
2.35k stars 144 forks source link

Regession with the latest changes #388

Closed ttytm closed 4 weeks ago

ttytm commented 1 month ago

Test moving back the last commits to 4694a2938931d814e0f318f5def2ef470b962f00 https://github.com/ttytm/v-webui/actions/runs/9340128030/job/25705316290

Test at current main 4466bcfc4e6ecfe92e244068d4bfbb1f5b231b59 https://github.com/ttytm/v-webui/actions/runs/9340147044/job/25705345755, or the last workflows on v-webui since updating to latest webui.

hassandraga commented 4 weeks ago

Probably this is an out of memory issue. Need more investigation.

hassandraga commented 4 weeks ago

I noticed that the failed one use clang, while the other one use gcc.

ttytm commented 4 weeks ago

Hey, I'm currently on my phone. But yes correct. The tests started to fail with clang on an Ubuntu runner. I think there were only four simple commits in between the above mentioned shas. When I remember correctly only one of would potentially cause the issue. It starts working again when reverting to the first mentioned Sha.

hassandraga commented 4 weeks ago

#define WEBUI_SPF(buffer, buffer_size, format, ...) snprintf(buffer, _webui_mb(buffer_size), format, ##__VA_ARGS__)

This is what causing Clang compiled program to crash in Linux. Working on it.

hassandraga commented 4 weeks ago

Fixed. Thank you @ttytm.

ttytm commented 4 weeks ago

Great work thank You!