search

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and HTML5 in the frontend, all in a lightweight portable lib.
https://webui.me
MIT License
2.35k stars 144 forks source link

Fix windows TLS CI #407

Closed ttytm closed 2 weeks ago

ttytm commented 3 weeks ago

Uploads the TLS Windows build as release artifact.

For now only the working GCC build.

To verify the TLS build, it can be found as an artifact in the workflow run of the PR.

hassandraga commented 3 weeks ago

Sorry, I don't get it, is this to only verify the TLS build? I'm trying to actually include the secure version in the archives.

However, the Win32 TLS build failed because of an issue in webui.h, I'm trying to solve it.

ttytm commented 3 weeks ago

I'm trying to actually include the secure version in the archives.

Yep this is what the PR does. I'm just failing to communicate:

Screenshot_20240612_175736

https://github.com/webui-dev/webui/actions/runs/9485767608?pr=407

ttytm commented 3 weeks ago

It will be part of the releases as well. When TlS building with msvc is resolved we can include it as well

ttytm commented 3 weeks ago

I would give a last refinement to the PR in a sec

hassandraga commented 3 weeks ago

Sure, I can't see the screenshot as GitHub servers recently has traffic issues... however, I'm working on webui\src\webview/WebView2.h(62): error C2061: syntax error: identifier 'ICoreWebView2AcceleratorKeyPressedEventArgs'.

hassandraga commented 2 weeks ago

Fixed (https://github.com/webui-dev/webui/commit/cc3df4f0409b5864d1c063b395e70fa7c2a06a2f). Now we can test this new CI.

ttytm commented 2 weeks ago

Good job, gonna rebase this one and enable msvc tls builds

hassandraga commented 2 weeks ago

I guess it will be better if we include the secure version of WebUI in the same archives we already have instead of creating new archives for TLS.

ttytm commented 2 weeks ago

I guess it will be better if we include the secure version of WebUI in the same archives we already have instead of creating new archives for TLS.

Okay, what name should we choose then for the libfile?

hassandraga commented 2 weeks ago

We just add -secure, the current makefiles already doing it. https://github.com/webui-dev/webui/releases/tag/nightly

ttytm commented 2 weeks ago

I see, I think then we can supersede this PR with #409