search

webui-dev / webui

Use any web browser or WebView as GUI, with your preferred language in the backend and HTML5 in the frontend, all in a lightweight portable lib.
https://webui.me
MIT License
2.35k stars 144 forks source link

Fix condition for release steps when pushing tags #415

Closed ttytm closed 2 weeks ago

ttytm commented 2 weeks ago

I simplified the release condition too much with one of the recent updates. We would encounter an issue on the next tag release (I already did in another project after making a similar change).

While creating a tag is a push event, the ref_name is not the branch name like main but the tag's name. So, the condition would be false when it shouldn't be.

hassandraga commented 2 weeks ago

image

Just to let you know, I'm testing the paid GitHub ARM runners... for some reason, the runners does not run!. I'm planning to do more testing, if does not work, I may probably more to an external paid runners services... however, if any of those work, the CI scripts may get changed.

I still prefer a complete cross-compiling solution with TLS using default runners... but need much time to fully do it.

ttytm commented 2 weeks ago

Yes I noticed the update. I don't have experience with github paid runners yet. There were always solutions without them. It'll be interesting to explore their functionalities. Let's see where things go.

ttytm commented 2 weeks ago

Solidifying the basics and improving testing in general is needed. The main repo still has no tests besides building. I think it will yield more benefits before starting endevours on more platforms.

ttytm commented 2 weeks ago

Does the runners cost per usage? I think it's better to ask first before I also start doing tests.

hassandraga commented 2 weeks ago

Yes it cost, but it's cheap, 0.004 I guess... You can try it as many as you want.