rename env PLUGIN_URL - Githubissues

webview / webview_deno

🌐 Deno bindings for webview, a tiny library for creating web-based desktop GUIs

https://deno.land/x/webview

MIT License

1.44k stars 74 forks source link

rename env PLUGIN_URL #145

Open milahu opened 2 years ago

milahu commented 2 years ago

the env name should be more absolute than PLUGIN_URL

https://github.com/webview/webview_deno/blob/9c3bff67c0b6ba2b5dc6066c15b3117da6ad7c68/src/ffi.ts#L4-L7

this env holds the folder of libwebview.so so rename to ...

WEBVIEW_DENO_LIBWEBVIEW? WEBVIEW_DENO_LIB? DENO_LIBWEBVIEW? DENO_WEBVIEW_LIB?

also its not an (optional) "plugin" but an essential dependency

fix merged in https://github.com/milahu/webview_deno