webwizo / laravel-shortcodes

Wordpress like shortcodes for Laravel 4.2, 5.x, 6.x, 7.x, 8.x, 9.x and 10.x
MIT License
214 stars 49 forks source link

PHP 8: Required parameter $shortcode follows optional parameter $data #64

Closed volkv closed 3 years ago

volkv commented 3 years ago

Hi! one thing is preventing migration to PHP 8.0 - optional parameter deprecated syntax src/View/View.php:29

thanks

webwizo commented 3 years ago

Thanks @volkv for your support.

browner12 commented 3 years ago

Running into the same or a similar issue in https://github.com/webwizo/laravel-shortcodes/blob/master/src/Compilers/Shortcode.php#L35

PHP 8 is throwing a deprecation notice for an optional parameter coming before a required one.