webworker01 / mmtools

Bash CLI tools for MM2
https://github.com/KomodoPlatform/atomicDEX-API
GNU General Public License v3.0
6 stars 8 forks source link

CHTA/KMD pair trading failure? #5

Closed ShorelineCrypto closed 11 months ago

ShorelineCrypto commented 11 months ago

mmtools as it is really outdated for KMD pair trading. I got trading failures at least twice this week without knowing what was going. Here are the errors on KMD/CHTA trading:

      "timestamp": 1694570142525,
        "event": {
          "type": "MakerPaymentTransactionFailed",
          "data": {
            "error": "maker_swap:599] utxo:1683] utxo:1687] rpc_clients:1490] JsonRpcError { client_info: \"coin: KMD\", request: JsonRpcRequest { jsonrpc: \"2.0\", id: \"12976\", method: \"blockchain.transaction.broadcast\", params: [String(\"0400008085202f8902e75407162962dd0a8793bc6b663e0fbfbbc15d411fdd1dd217e1f062bafefcfb000000006a47304402205d34d3f465dfe39114c64ddcfe45e46b368e51298fbe56c44353e7504338c13002205b54217f654afd0af3b85fca6a5410dc61bf097a753d25e191ff7e5621f86b9e0121027ab026fa81aa288b1e2bcaedb7dd16e268d24d7ccf52301f12d957b91bb5c150ffffffffd0d76eebfa1a3cbadbb85db155aa880f3a3420e773bc15b7258542b8133b41d5010000006a4730440220404337c09b576b06fd696500b52d9d28aa10af4487d782b4ac5e4914955a391c0220113a148a2f1eb452cfb08c758799e4e09dfc1dde04939e08c28fdee6c53f2f7f0121027ab026fa81aa288b1e2bcaedb7dd16e268d24d7ccf52301f12d957b91bb5c150ffffffff0387d4e70b0000000017a9149ba5ba60f7840034052a6b2d2737ae45a7dcc802870000000000000000166a14fe61815ba8aa44868fb85dc04ef982e047660b364963e338000000001976a9148ab906d01edd56c3f2246cf7d6fd85171fb26d4a88ac21150165000000000000000000000000000000\")] }, error: Response(electrum2.cipig.net:20001, Object({\"code\": Number(1), \"message\": String(\"the transaction was rejected by network rules.\\n\\n16: bad-txns-in-belowout\\n[0400008085202f8902e75407162962dd0a8793bc6b663e0fbfbbc15d411fdd1dd217e1f062bafefcfb000000006a47304402205d34d3f465dfe39114c64ddcfe45e46b368e51298fbe56c44353e7504338c13002205b54217f654afd0af3b85fca6a5410dc61bf097a753d25e191ff7e5621f86b9e0121027ab026fa81aa288b1e2bcaedb7dd16e268d24d7ccf52301f12d957b91bb5c150ffffffffd0d76eebfa1a3cbadbb85db155aa880f3a3420e773bc15b7258542b8133b41d5010000006a4730440220404337c09b576b06fd696500b52d9d28aa10af4487d782b4ac5e4914955a391c0220113a148a2f1eb452cfb08c758799e4e09dfc1dde04939e08c28fdee6c53f2f7f0121027ab026fa81aa288b1e2bcaedb7dd16e268d24d7ccf52301f12d957b91bb5c150ffffffff0387d4e70b0000000017a9149ba5ba60f7840034052a6b2d2737ae45a7dcc802870000000000000000166a14fe61815ba8aa44868fb85dc04ef982e047660b364963e338000000001976a9148ab906d01edd56c3f2246cf7d6fd85171fb26d4a88ac21150165000000000000000000000000000000]\")})) }"
          }
        }

The trading status is "Finished", but obviously the trading failed. The failed atomic swap trading will be refunded in 12 hours. Komodo KMD recently in July 2023 had hard fork, which could be reason for the failure. Cheetahcoin (CHTA) never had any hard fork, nor soft fork in recent months.

ShorelineCrypto commented 11 months ago

Here are tips from cipi in Komodo discord channel:

cipi — 08/31/2023 10:10 PM yes, you need latest mm2 from https://github.com/KomodoPlatform/komodo-defi-framework/releases and latest coins file from https://github.com/KomodoPlatform/coins/blob/master/coins, else a lot of things will not work, like KMD swaps and ZEC swaps and some other things, like DOGE fee too high cipi — 09/01/2023 11:10 AM there are binaries mm2-ef8961495-android-aarch64-CI.zip and mm2-ef8961495-android-armv7-CI.zip... don't they work? thing is that KMD swaps will not work at all with the old mm2 version because of the changed APR

ShorelineCrypto commented 11 months ago

Eventually today figured out and fixed issue. mmtools uses mm2 compiled from legacy atomic-API at this path ~/atomicDEX-API/target/debug/mm2 I replaced this file, modify password to add one special character as new mm2 requires, the KMD pair now trades well. DOGE is no longer supported on mmtools, which is fine now.