be more tolerant on PACKAGE_NAME argument

webxdc / hello

Sample project with a simple implementation of the webxdc read and write APIs

The Unlicense

29 stars 7 forks source link

be more tolerant on PACKAGE_NAME argument #12

Closed r10s closed 2 years ago

r10s commented 2 years ago

when a package name is given to create-xdc.sh, this may be just a copy+pasted filename. that, however, results in double .xdc extensions.

this pr accepts PACKAGE_NAME with or without .xdc extensions, of course, when creating the final ZIP, .xdc is always added, however only once :)

moreover, this pr documents the weird string manipulation commands.

r10s commented 2 years ago

thanks for review! this time i was really unsure about the weird syntax, i have never noticed that before i've seen the construct @adbenitez made in the line above :)