webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

fix: Rework import #130

Closed Septias closed 1 year ago

Septias commented 1 year ago

close #120

Septias commented 1 year ago

looks good but please add a test to call at least the dir-function using the example-xdc's

This is done plenty of times in the python tests

hpk42 commented 1 year ago

On Thu, Jun 29, 2023 at 08:50 -0700, Sebastian Klähn wrote:

looks good but please add a test to call at least the dir-function using the example-xdc's

This is done plenty of times in the python tests

ah right, that's probably enough then :)

link2xt commented 1 year ago

I think the import path should be a required argument without a CWD default.

I expect that when I run a command like git add or gh release upload without arguments, it prints usage and fails, not adds everything from the current directory or uploads every file to the release.