feat: App index updates

webxdc / store

XDC store, migrated to codeberg

https://codeberg.org/webxdc/store

5 stars 0 forks source link

feat: App index updates #132

Closed Septias closed 1 year ago

Septias commented 1 year ago

Follow up on #115

I'm sorry for this huuuuuge PR... I'll try to split better in the future, but many of the added lines are part of changed .lock files, tests, and snapshots so code changes are not too much. The PR solves the same thing as #115 but has some fundamental differences:

Version field is now a number
AppInfo.active has been removed
Frontend can send a cache list (apps: [app_id, version]) and frontend will send updates if needed
I finally came to introduce frontend testing :)

Attention @adbenitez: I made some changes to the initial migrations so you have to rebuild the bot-db from scratch.

closes #36 closes #73 closes #124 closes #123

Septias commented 1 year ago

While reading a lot of the existing code I found that serial and version should be u32 instead of i32, but I will not add that change to this pr as it is already big enough.

Simon-Laux commented 1 year ago

Version field is now a number

why?

I finally came to introduce frontend testing :)

🚀

adbenitez commented 1 year ago

issues:

once I saw the "this version is outdated you have to upgrade" dialog when it was a recently downloaded instance of the store, and after closing it and open it again then the dialog disappeared so I guess there is some bug with the upgrade of the store itself
I pressed the "refresh" button after importing several new apps, but the frontend didn't refresh, when I closed and opened the store again then I saw all the apps in the list, they got processed on start of the app but somehow the event received in "real time" with the store open was not processed

adbenitez commented 1 year ago

sidenote for the future: solving 4 somewhat unrelated issues in a single PR touching 36 files, adding +2,002 lines and removing 354, makes it hard to review, it is better small atomic PRs

hpk42 commented 1 year ago

Version field is now a number

why?

It is an internal incrementing number because it's sufficient. The app can display whatever "human readable" version it wants. An XDCs app is not a node package or a cargo crate or a python wheel. It's more like an apk which is also internally tracked by incrementing numbers. Several people have discussed this and if you don't have serious objections let's put the discussion to rest.

hpk42 commented 1 year ago

sidenote for the future: solving 4 somewhat unrelated issues in a single PR touching 36 files, adding +2,002 lines and removing 354, makes it hard to review, it is better small atomic PRs

I think Sebi acknowledged this already in the pr description. Not much use to repeat it. Probably background is that he mainly worked on the weekend and is not much available the coming week. So let's discuss tomorrow (Monday) how to proceed.

adbenitez commented 1 year ago

I think Sebi acknowledged this already in the pr description.

totally overlooked it, my eyes jumped right to the mention in the description =)