search

webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

feat: Add frontend tests to ci #142

Closed Septias closed 1 year ago

Septias commented 1 year ago

close #137

link2xt commented 1 year ago

There is a yaml parsing error: https://github.com/webxdc/store/actions/runs/5449095764

link2xt commented 1 year ago

Somehow one test is consistently failing for me when I run it locally: 1

Septias commented 1 year ago

You need node version 16 @link2xt I had the same issue and wasted way too much time fixing it myself...

link2xt commented 1 year ago

You need node version 16 @link2xt I had the same issue and wasted way too much time fixing it myself...

But I already have node 20, seems strange that I should downgrade. Is there an upstream issue for this bug?

Septias commented 1 year ago

Haven't found one. It is a solidjs bug that you can't use createStore in tests like that.

link2xt commented 1 year ago

Haven't found one. It is a solidjs bug that you can't use createStore in tests like that.

Could you open one in https://github.com/solidjs/solid/issues ? node.js will upgrade on CI runners sooner or later as well and break the tests. If we only support a particular node.js version, then I think it should be installed with https://github.com/actions/setup-node so it is fixed.

Septias commented 1 year ago

We might be lucky and it never breaks because it is fixed in time though

link2xt commented 1 year ago

We might be lucky and it never breaks because it is fixed in time though

But there is even no issue in solidjs bugtracker, so more likely it will not be fixed because the devs are not aware of it.

link2xt commented 1 year ago

Moved failing tests issue to #152