webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

Frontend tests fail with Node.js 20 #152

Closed link2xt closed 1 year ago

link2xt commented 1 year ago

https://github.com/webxdc/store/pull/142#issuecomment-1620216852

Septias commented 1 year ago

Would like to close this as there is nothing we can do against it in this repo and it's also not a real problem as nothing breaks atm. As soon as something breaks we will notice I believe

link2xt commented 1 year ago

We can report this upstream at least.

Currently the tests fail for me as node installed from the package manager is version 20.

link2xt commented 1 year ago

For me even the following test fails:

import { describe, test } from 'vitest'
import { createStore } from 'solid-js/store'

describe('Store tests', () => {
  test('Store test', async () => {
    createStore({})
  })
})
link2xt commented 1 year ago

Made a minimal example reproducing the bug: https://github.com/link2xt/vite-solidjs-plugin-bug

link2xt commented 1 year ago

Made an upstream issue: https://github.com/solidjs/vite-plugin-solid/issues/104

Septias commented 1 year ago

Nice, thank you :)

Septias commented 1 year ago

closing this as it is not a real problem for the bot atm