webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

refactoring: Remove `version` in favor of `tag_name` #190

Closed Septias closed 1 year ago

Septias commented 1 year ago

Change the version field to tage_name. While doing so I also refactored some of the code, mainly:

closes #184

hpk42 commented 1 year ago

tested the branch (but only quickly) and it seems to work nicely. a bit unsure about adding "Tag: ...." as a new metadata line, how about "Tag: v2.0.2 from 7/19/2023" instead of Date and Tag lines? cc @r10s image

r10s commented 1 year ago

a bit unsure about adding "Tag: ...." as a new metadata line, how about "Tag: v2.0.2 from 7/19/2023" instead of Date and Tag lines? cc @r10s

i understand that we want to be more precise in the data structures, however, for the average user, i think "Tag" is too technical in the UI, "Version" would be much better, ppl understand what that is.

if we do not want the word "Version" or "Release" in the UI ("Version v2.0.2 from 7/19/2023" or "Release v2.0.2 from 7/19/2023"), maybe just append the tag in brackets to the date line?

Date: 7/19/2023 (v2.0.2)

without much explaining what it is exactly - end user will see it as a version, devs can know it is just a tag.

in general, however, i think it is a good idea to have tag and date in the same line, they belong strongly together