search

webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

Disable Eruda debugger on the main branch #220

Closed link2xt closed 1 year ago

link2xt commented 1 year ago

It is currently always enabled here, but should be enabled only for PRs: https://github.com/webxdc/store/blob/85059a178c3629312510a1610947ec9773e74c7d/.github/workflows/ci.yaml#L83-L84

adbenitez commented 1 year ago

I am not sure about only for PRs, ex. the testing bot also needs to test current main branch, wouldn't be better to have a "stable" branch or release tags and then build for deployment in those?

adbenitez commented 1 year ago

ex. we already have release.yml that will release for production on version tags, the ci.yml only builds testing stuff