webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

chore: update SurrealDB to make it compile with GCC 13 #4

Closed link2xt closed 1 year ago

link2xt commented 1 year ago

This fixes https://github.com/surrealdb/surrealdb/issues/2017 by upgrading rocksdb to the version that compiles with GCC 13: https://github.com/surrealdb/surrealdb/pull/2018

This helps a bit with #2 so the bot compiles on my machine.

Septias commented 1 year ago

I reverted this change because on master, the db would not start. I raised an issue and will wait for the outcome before proceeding here.

link2xt commented 1 year ago

I raised an issue and will wait for the outcome before proceeding here.

Where is the issue?

EDIT: I guess it is this on: https://github.com/surrealdb/surrealdb/issues/2043

link2xt commented 1 year ago

@Septias Maybe prioritize getting rid of SurrealDB then? It has to be done at some point anyway and slows down development, because it is slow to compile rocksdb on CI, the latest released verison has problems compiling with the latest GCC and unreleased fails has critical bug that prevent starting the app that we cannot resolve ourselves.

Septias commented 1 year ago

Yeah I really want to move away from surrealdb

rushmorem commented 1 year ago

slows down development, because it is slow to compile rocksdb on CI

Yes RocksDB does take a while to compile. Instead of using RocksDB in development though, you could use the memory engine and only switch to RocksDB during deployment. The Any engine really makes this easy.

Septias commented 1 year ago

Thank you for the suggestion, but also Licensing is a problem for us. We want to share the bot without any restrictions