webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

add results of some high level discussion between sebi, adb and me about MVP #67

Closed hpk42 closed 1 year ago

hpk42 commented 1 year ago

(for reference)

adbenitez commented 1 year ago

this got merged too quickly, the fields where updated but the mock data format was not updated

that is why some bit of PR workflow culture is not bad, even if it seems some trivial change that could be merged directly it is good to let some people see it and review, we can always overlook something

Septias commented 1 year ago

It is only to add the result of that discussion. No one mentioned to rewrite everything else directly.

adbenitez commented 1 year ago

It is only to add the result of that discussion. No one mentioned to rewrite everything else directly.

but the readme is already updated while the code is not, so at the moment things are out of sync, until the code is actually updated to follow what the readme says, not the big deal it is just that it would be better in the future to do that kind of changes as atomic operations, otherwise it is confusing ex. for me that I am editing the mock data