search

webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

use icon instead of 'add' #70

Closed Septias closed 1 year ago

Septias commented 1 year ago

image

adbenitez commented 1 year ago

@r10s we need your opinion with this :)

besides the above "send" icon, another options I like more are:

like the Telegram&WhatsApp icon for sharing/forwarding a message to another chat:

image_2023-06-19_15-06-29

another option is to use a share icon similar to the share button on DC-android:

image_2023-06-19_15-08-05

that two options fit with the screen that comes with the sendToChat() action, ex. desktop and android show the "share with..." string, it is the same screen than the share-to-delta-chat action etc

extra context: we are changing to an icon because it doesn't need translation and it is shorter than the "send in chat" button we previously considered which doesn't fit well in phone screens

r10s commented 1 year ago

as there is only one action anyways, i do not think, any of the icons or text are totally bad choices. i have a slight preference for the "forward arrow" from telegram/whatsapp - one can imagine that also eg. for other situations, where the usual send button does not fit.

i also like a textual button (as in gplay, apple), however, if that has to read eg. "Send to Chat", this is easily too wide, indeed.

we are changing to an icon because it doesn't need translation

i do not really buy that point:) for accessibility, one should set a title as well - which is also useful as a tooltip on desktop.

and it is shorter than the "send in chat"

a bit unrelated, however: there is currently too much space wasted anyways, esp. horizontally. i would not add a border but a line between the items and make the items wider by that. this also looks cleaner.

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/appstore-bot-70.tar.gz

adbenitez commented 1 year ago

i do not really buy that point:) for accessibility, one should set a title as well - which is also useful as a tooltip on desktop.

I didn't express it correctly, it is not that it doesn't need a label, ok, you can have the tooltip in English but if you also have an icon at least someone not speaking the language used in the app, can already guess what is the meaning by the depicted icon

Septias commented 1 year ago

@adbenitez I changed the icon, can you approve?

adbenitez commented 1 year ago

I am not approving because I don't like the current round send button icon shown in the screenshot and I'm in favor of the whatsapp/telegram arrow button, but if others agree with this one it is fine, anyway it is fine to let this PR open and see other opinions, this is no blocker or?

Septias commented 1 year ago

I added the forward icon