webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

implement app updates for the app index #73

Closed Septias closed 1 year ago

Septias commented 1 year ago

hence update of downloaded apps happen automatically when the user use the app and a "update index" request is sent, because of this, a way to remove downloaded apps from cache/local-storage is needed, so user have a way to stop the updates of an app downloaded once to try but never wanted/used anymore, for that aspect see issue https://github.com/webxdc/store/issues/123

adbenitez commented 1 year ago

from the point of view of the bot I would say the issue should be rather: a) add app_id and version to the appstore.xdc file itself and/or: b) check app_id and version is defined in the submitted apps

"add versioning for webxdcs" is not clear to me :thinking: , I created an issue to discuss the specs part for all webxdcs at: https://github.com/webxdc/webxdc_docs/issues/58

that is not blocking the bot from having a temporal implementation via the a) and b) points

adbenitez commented 1 year ago

UPDATE: for a), https://github.com/webxdc/appstore-bot/issues/66 already exists

link2xt commented 1 year ago

What is the "keep files importing problem"?

Septias commented 1 year ago

Your Idea was to remove it in some pr. If we have proper versioning we can get rid of all this moving to different folder etc, just have on folder with all the webxdcs in it and when run, the bot will just compare all versions and update if needed.

link2xt commented 1 year ago

It was not clear to me that is a reference to the keep_files argument of the import subcommand added in #53.

adbenitez commented 1 year ago

What is the "keep files importing problem"?

currently if you run the cli to import the same folder with apps, they will be imported as duplicates, also if you try to import an updated version of an already existing app