Closed Septias closed 1 year ago
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
true, will remove it later
Download the preview at https://download.delta.chat/store/preview/appstore-bot-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/xdcstore-83.tar.gz
Download the preview at https://download.delta.chat/store/preview/xdcstore-83.tar.gz
so after a bit of fiddling (the initialization sequence it not too nice but that's off-topic) i was able to run the bot, got the store.xdc and opened it, downloaded an app, then
frontend/build-files/shop/manifest.toml
but then updating the app-index in the still running store.xdc did not cause a warning, only when i tried to download a new app the attached screen appeared, but no new store.xdc arrived in my store-chat.
sebi, please provide the precise steps how this PR can be manually tested (i spent ~45 minutes now and am still not sure if i did things right) especially if there are not automated tests.
Bot test steps and test result is as implemented. We at some point agreed to do Webxdc updating lazily. For testing, you could also edit the manifest.romt of the bundled store.xdc in the bot-data directory
Testing is hard to do because there is no easy to implement e2e testing for bot and DC. I can add a python test later though
could you simply clarify how a manual test of the code can be done? (i am aware that having an automated test for this PR is not easy or feasible currently) -- What do you mean with updating "lazily"? It really helps if you are a bit more explicit about these things because otherwise i need to spend a lot of time trying to find out myself the details, probably like 5x more than it would take you to just be more explicit.
@hpk I added the download confirmation we talked about earlier and for me, the frontend is disabled even when clicking update.
I tested it, this PR came a bit early before getting the in-place core api, so I am not sure it is good idea to invest too much efforts in making a UI that works well for the current situation, the upcoming API workflow will be like:
recomendation: show the store version somewhere inside the app
Adds upgrading for the store frontend xdcs (the store.xdc, submit.xdc etc.) This provides the starting point for #79
Idea:
bot-data
. (With RUST_LOG=info set it will show the loaded versions in the console).manifest.toml
inbot-data
, the bot will load the newer version upon startup.This is also shown in a python test