search

webxdc / store

XDC store, migrated to codeberg
https://codeberg.org/webxdc/store
5 stars 0 forks source link

improve README.md #90

Closed adbenitez closed 1 year ago

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/appstore-bot-90.tar.gz

Septias commented 1 year ago

Can you create a PR-draft instead of putting [WIP] in the heading?

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

github-actions[bot] commented 1 year ago

Download the preview at https://download.delta.chat/store/preview/xdcstore-90.tar.gz

adbenitez commented 1 year ago

test are failing :thinking: it is hard for me to make sense of all the long logs of pytest, cc @link2xt

hpk42 commented 1 year ago

yes, test logs are much too verbose -- don't think that tracing the core is really helpful for the bot -- tracing the events (which we already do and print out) should be enough usually. but that's for a separate PR.

adbenitez commented 1 year ago

@hpk42, @link2xt I updated the README to not use /path/to/xdcstore and explain that it is assumed that you added the binary to PATH but that you can run the binary directly

about the "Installing pre-built binary releases" section, I think it is fine, it is marked as TODO as other parts of the readme, I don't expect anyone besides us setting up the store in current state for production, and in such case we can create a release, which we need to do anyway for setting up tarball releases in CI tagging of versions, setting up from source is too much unnecessary work for someone that just want to use this, and we already have a ./scripts/dist.sh script