Add livecycle buttons - Githubissues

webxdc / store

XDC store, migrated to codeberg

https://codeberg.org/webxdc/store

5 stars 0 forks source link

Add livecycle buttons #99

Closed Septias closed 1 year ago

Septias commented 1 year ago

This PR adds livecycle buttons for the state of the xdc.

From top to bottom in the image these states are represented:

Read to download
Downloading
Download error
Received (ready to forward)

Now only pressing forward will actuall send the webxdc to some chat.

closes #91

adbenitez commented 1 year ago

I think the icons and colors are fine, but I recommend putting text in the button as well, not only the icon

ex. beside the icon: Download, Downloading..., Error, Share

hpk42 commented 1 year ago

an interesting improvement -- I didn't test this PR myself (and won't today as things stand) but would be fine to merge it as it improves the current state. Note however that there also is the "update available" state -- i.e. you can share the current version of an app (it's downloaded) but there also is a new version available.

Septias commented 1 year ago

Yeah I know @hpk42 , I will add that as soon as updating is actually supported

Septias commented 1 year ago

I think the icons and colors are fine, but I recommend putting text in the button as well, not only the icon

ex. beside the icon: Download, Downloading..., Error, Share

I believe the text will just make it more clumbsy while not adding enough benefit.