search

webxdc / webxdc-dev

A development server for webxdc apps
The Unlicense
18 stars 4 forks source link

feat: make instance iframes resizeable #37

Open WofWca opened 1 year ago

adbenitez commented 1 year ago

@WofWca mmmmh thinking a bit about this, I don't think it is necessary, because the emulator already supports opening the instances in a new tab, then you can use there proper mobile screen tools from the browser's developer tools with proper "tap" emulation

WofWca commented 1 year ago

You can, but I think this feature is not just for writing CSS for different screen sizes. It's for more customized interaction testing setup.

adbenitez commented 1 year ago

I don't understand what you mean, but as I commented, you can already resize the app at taste opening in a new tab, there is no need for superfluous features, allowing to resize the iframe opens the door for mistakes like the user accidentally changing size then there is not a button to reset size etc. and the gain of resizing the emulator instances iframes is low and ugly

WofWca commented 1 year ago

I'm saying that I understand that you can resize the window in a separate tab, but you may still want to also do it on the main page of this tool. For example, when you have your code editor on the right on your monitor an the webxdc-dev tab on the left, and two (or more) app instances don't quite fit in one row because they're too wide.

I don't think this feature is big enough to worry about potential future problems. It can easily be removed if they do arise.