search

webyonet / react-native-android-location-services-dialog-box

React Native Android Location Services Dialog Box
MIT License
182 stars 50 forks source link

LocationServicesDialogBoxModule is not abstract and does not override abstract method onActivityResult(int,int,Intent) in ActivityEventListener #5

Closed samah2100 closed 7 years ago

samah2100 commented 7 years ago

I'm using RN 0.26.0 and after installing "react-native-android-location-services-dialog-box" I got this error

...\showlocationservicesdialogbox\LocationServicesDialogBoxModule.java:12: error: LocationServicesDialogBoxModule is not abstract and does not override abstract method onActivityResult(int,int,Intent) in ActivityEventListener class LocationServicesDialogBoxModule extends ReactContextBaseJavaModule implements ActivityEventListener { ^ C:\RN\1\node_modules\react-native-android-location-services-dialog-box\android\src\main\java\com\showlocationservicesdialogbox\LocationServicesDialogBoxModule.java:22: error: method does not override or implement a method from a supertype @Override ^ C:\RN\1\node_modules\react-native-android-location-services-dialog-box\android\src\main\java\com\showlocationservicesdialogbox\LocationServicesDialogBoxModule.java:77: error: method does not override or implement a method from a supertype @Override ^ 3 errors FAILED

FAILURE: Build failed with an exception.

webyonet commented 7 years ago

Please use rn 30 and newer versions v1.1.7 For other lower versions, use 1.1.4.

webyonet commented 7 years ago

Please see rn30 and the breaking change of the above.

roots-ai commented 6 years ago

I am using the below config and still the above error.

"react-native": "0.44.3",
"react-native-android-location-services-dialog-box": "2.3.2",
webyonet commented 6 years ago

@roots-ai please read releases note

itinance commented 6 years ago

We get this compilation error since we upgraded to RN 0.50, running latest version "react-native-android-location-services-dialog-box": "2.4.3"

Any ideas?

itinance commented 6 years ago

Seems that with latest RN some compatibility breaks happened for android that needs to be applied here.

itinance commented 6 years ago

I've figured out that these compilation errors happens when "react-native-image-crop-picker" is installed in an application. Without this library everything gets compiled.

Any ideas?

UPDATE: it happenes due to a maven-url that is necessary for react-native-image-crop-picker. I opened an issue for that: https://github.com/ivpusic/react-native-image-crop-picker/issues/548

webyonet commented 6 years ago

this bug may be a react-native link issue. try to manual installation please.