search

webyonet / react-native-android-location-services-dialog-box

React Native Android Location Services Dialog Box
MIT License
182 stars 50 forks source link

compile -> compileOnly in build.gradle #72

Closed shubham-agrawal closed 5 years ago

shubham-agrawal commented 5 years ago

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018.

webyonet commented 5 years ago

thanks

betopompolo commented 5 years ago

@webyonet does this change is available in v2.8.2?

webyonet commented 5 years ago

@betopompolo yes

betopompolo commented 5 years ago

@webyonet thank you! So should I change the compile to compileOnly or to implementation? The Readme is still using compile 🤔

webyonet commented 5 years ago

@betopompolo compileOnly is still valid. It was added in 3.0 to replace provided and not compile. (provided introduced when Gradle didn't have a configuration name for that use-case and named it after Maven's provided scope.

betopompolo commented 5 years ago

@webyonet ok! I added implementation project(':react-native-android-location-services-dialog-box') in android/app/build.gradle and it's working now. Thank you for your time!