wechaty / docusaurus

Wechaty Official Website for Documentations, Powered by Docusaurus.
https://wechaty.js.org/docs/
Other
112 stars 343 forks source link

Improve Dark Mode UI of the Landing Page and Wechaty #1354

Open Rohitesh-Kumar-Jain opened 2 years ago

Rohitesh-Kumar-Jain commented 2 years ago

Landing Page Team under GSoD'21 @ created the new landing page.

But I feel that the Dark mode UI of that page needs some improvement.

Currently, the UI looks like this:

Some text is not visible as you can see.

Screenshot 2021-10-15 at 10 54 09 AM

What I suggest is to merge the remaining PRs of the Landing Page first, so that the team can work on this issue as a whole.

sajen-k commented 2 years ago

@Rohitesh-Kumar-Jain There will be following PR once we merged all the 8 PRs and that final PR will consist changes in the index file as well as docusaurus.config in which the dark mode option will be removed. According to the docusaurus documentation if we change the default landing page provided by the docusaurus the dark mode won't be applied so we won't be able to use the dark mode and we need to work in that part as we created the landing page. So as of now there will be another PR for merging all the components in the index file and it will also remove the dark mode toggle option. If you have anymore question let me know. Thank you.

sajen-k commented 2 years ago

As you can see in the PR preview photos that we attached for all the section PRs you cannot see the dark mode toggle option.

Rohitesh-Kumar-Jain commented 2 years ago

Can't we improve the dark mode UI, instead of removing that 🤔 Ik that will be some work, but If possible add the dark UI as well.

Writing all this work on your resume will add stars to your profile, and will give you something more to speak in interviews about your projects ⭐

Rohitesh-Kumar-Jain commented 2 years ago

@encodeArnab and @sajenjeshan1222 you have removed Dark UI from the whole of the Wechaty, and that's not acceptable.

What I am talking about is that earlier we had a feature for the dark mode for documentation, consider ss on. #1098 and #1126.

What's the point of adding a feature on the cost of removing an exiting one 🤔

Kindly at least restore the dark UI for the rest of the Wechaty, if you don't wish to create the dark theme for the landing page itself.

ps : I am not asking to create a new dark theme, I am asking to restore the existing theme on the rest of the website, which you must restore in order to complete your project :)

Rohitesh-Kumar-Jain commented 2 years ago

As you can see in the PR preview photos that we attached for all the section PRs you cannot see the dark mode toggle option.

I was revisiting the prototype that you submitted, and that clearly had the dark mode toggle option...

https://www.figma.com/proto/L5MS8HqF0g5hbHdkgqUH1o/wechaty-landing-page?node-id=143%3A0&scaling=min-zoom&page-id=0%3A1

Rohitesh-Kumar-Jain commented 2 years ago

The new dark mode seems good, not sure the original dark mode had this theme, but this new theme looks good to me.

Screen Shot 2021-10-20 at 17 18 59-fullpage

Rohitesh-Kumar-Jain commented 2 years ago

@sajenjeshan1222 and @encodeArnab have made a decent enough dark mode for the Landing page, but someone might be further interested in improving the UI (maybe some new contributor who might look for easier tasks to get started with) hence reopening the issue.