Closed timor-m closed 1 month ago
@huan Can you review it for me when you have time?
Please make sure the following requirements have been met for your PR before we can continue reviewing it:
[CLA | not signed yet]
button from the comments.npm test
) @huan Thank you for your reply. The CLA has been completed, but the github actions test has not yet been completed.
Hi @timor-m , I think the cross-env
and npm-run-all
will be installed even without the direct dependencies. Please correct me if I'm wrong.
This PR includes many unrelated changes, including the version upgrade. Upgrading the version to the latest stable version is great, but the best practice would be to create a separate PR to do that.
I will close this PR for now, and you are welcome to create an new one by following the best practices.
add the cross-env package to dependencies
Checklist
Description
please describe the changes that you are making
for features, please describe how to use the new feature
please include a reference to an existing issue, if applicable
Does this PR introduce a breaking change?