wechaty / getting-started

A Starter Project Template for Wechaty works out-of-the-box
https://gitpod.io/#https://github.com/wechaty/wechaty-getting-started
Apache License 2.0
772 stars 342 forks source link

Fix: add the cross-env package to dependencies #301

Closed timor-m closed 1 month ago

timor-m commented 6 months ago

add the cross-env package to dependencies

[√ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[√ ] No
CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

timor-m commented 6 months ago

@huan Can you review it for me when you have time?

huan commented 6 months ago

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)
timor-m commented 6 months ago

@huan Thank you for your reply. The CLA has been completed, but the github actions test has not yet been completed.

huan commented 1 month ago

Hi @timor-m , I think the cross-env and npm-run-all will be installed even without the direct dependencies. Please correct me if I'm wrong.

This PR includes many unrelated changes, including the version upgrade. Upgrading the version to the latest stable version is great, but the best practice would be to create a separate PR to do that.

I will close this PR for now, and you are welcome to create an new one by following the best practices.