search

wechaty / go-wechaty

Go Wechaty is a Conversational SDK for Chatbot Makers Written in Go
https://github.com/wechaty/go-wechaty-getting-started
Apache License 2.0
484 stars 92 forks source link

About go.sum file submit repository #33

Open dingdayu opened 4 years ago

dingdayu commented 4 years ago

We continue to discuss whether go.sum is submitted to the repository.

I suggest to submit this file.

As @eslizn quoted Go official discussion on this issue: https://github.com/golang/go/wiki/Modules#releasing-modules-all-versions

Related documents:

submit go.sum the reason:

Many open source projects are like this.

huan commented 4 years ago

Thank you very much for starting this discussion thread for whether we should commit the go.sum file.

other languages separate versions and dependencies.

I have to say that I can not agree with you on the above sentence because it seems that all languages are putting the versions and dependencies together.

For example:

In node, we have the versions in our dependencies file package.json:

    "wechaty-puppet": "^0.25.1",
    "wechaty-puppet-hostie": "^0.7.1",

In Go, we have the versions in our dependencies file go.mod:

    github.com/hashicorp/golang-lru v0.5.4
    github.com/otiai10/opengraph v1.1.1

And in Java, we have the versions in our dependencies file pom.xml

            <dependency>
                <groupId>io.grpc</groupId>
                <artifactId>grpc-protobuf</artifactId>
                <version>1.28.0</version>
            </dependency>

So I believe either go.sum or package-lock.json are trying to solve the other problem.

dingdayu commented 4 years ago

Thank you very much for starting this discussion thread for whether we should commit the go.sum file.

other languages separate versions and dependencies.

I have to say that I can not agree with you on the above sentence because it seems that all languages are putting the versions and dependencies together.

For example:

In node, we have the versions in our dependencies file package.json:

    "wechaty-puppet": "^0.25.1",
    "wechaty-puppet-hostie": "^0.7.1",

In Go, we have the versions in our dependencies file go.mod:

  github.com/hashicorp/golang-lru v0.5.4
  github.com/otiai10/opengraph v1.1.1

In Java, we have the versions in our dependencies file pom.xml

            <dependency>
                <groupId>io.grpc</groupId>
                <artifactId>grpc-protobuf</artifactId>
                <version>1.28.0</version>
            </dependency>

So I believe either go.sum or package-lock.json are trying to solve the other problem.

Oh yes, I think I need to modify my expression.