search

wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet
https://wechaty.github.io/grpc/
Apache License 2.0
25 stars 22 forks source link

Support forwarding message #105

Closed jcai closed 3 years ago

huan commented 3 years ago

Thanks for creating a PR for adding the messageForward service to our gRPC!

According to our discussion at https://github.com/wechaty/wechaty/issues/2093 , I believe we should also add a service for this request/response, and also make the messageForward method in our wechaty-puppet to be abstract.

Do you want to merge this PR first, or you want to make those additional modifications together?

I'd like to suggest that we should add the gRPC service messageForward with this PR to make the PR complete.

jcai commented 3 years ago

I have added MessageForward service definition,but I can't fix the test error.

huan commented 3 years ago

@windmemory I have modified this PR based on our discussion this afternoon, please let me know if you have any comments, and help me to approve it after everything is ok for you.

Thank you very much.

su-chang commented 3 years ago

Related issue: https://github.com/wechaty/wechaty-puppet-service/issues/135