search

wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet
https://wechaty.github.io/grpc/
Apache License 2.0
25 stars 22 forks source link

Add room member #122

Closed su-chang closed 3 years ago

windmemory commented 3 years ago

Seems like we need to fix this before we move forward on this PR:

wechaty/puppet/friendship.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-grpc hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--grpc_out:

From https://github.com/wechaty/grpc/pull/122/checks?check_run_id=2085158012

huan commented 3 years ago

@windmemory It seems that we are running into #109

I hope the grpc ecosystem that we are using can support this new featuree.

We have 2 options now:

  1. Try to upgrade our tools to support optional with proto3, this will be the best choice
  2. If we can not upgrade our tools to support it, then we can use import "google/protobuf/wrappers.proto like other optional fields. https://github.com/wechaty/grpc/blob/b5e4cc9226771a5f2a01c84cb9c269ffc512162f/proto/wechaty/puppet/contact.proto#L104-L107
windmemory commented 3 years ago

Vote for wrapper for now, since using wrapper won't block this feature to be done.

huan commented 3 years ago

I'm ok with that, please go ahead with it.

windmemory commented 3 years ago

Let's bump the version so we can automatically publish it after we merge this PR.

huan commented 3 years ago

Thank you very much for adding this new feature to our gRPC service!