search

wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet
https://wechaty.github.io/grpc/
Apache License 2.0
25 stars 22 forks source link

Room invitation link #143

Closed su-chang closed 3 years ago

huan commented 3 years ago

Dear @su-chang ,

Thank your very much for the PR.

However, a PR should be linked to the related issue which described the problem in detail, so that we can review it easily with enough background information, at the same time, the code can linked to the right information for the future contributor who need to understand the code better.

We have discussed the above topic for multiple times, I feel that you have not get it that's the reason I post this and I hope we can follow the above open source best practice in the future.

Please let me know what you think, thank you very much.

su-chang commented 3 years ago

Sorry, it's my mistake. I will force myself to follow it. Thank you.

BTW, I will close this one due to there has same PR here: https://github.com/wechaty/grpc/pull/138

huan commented 3 years ago

Thank you very much for following the above best practices, appreciate it.