Closed su-chang closed 2 years ago
I have noticed that we have a design which needs to be improved:
Please feel free to add the improvements to this PR to refactoring them, and I will work on it later as well.
Thank you very much.
@huan ping
@su-chang Thanks for the improvements!
Sorry for the late reply because we are also considering to use the optional
from the latest version of proto3, which is the best practice and will replace the google.protobuf.StringValue
.
If not using optional would add complexity or ambiguity, then use optional primitive fields. Wrapper types must not be used going forward. — Optional Primitive Fields
I will take time to merge this PR this week, thank you very much for your patience.
CI Green!
I will merge this PR, but please do read my comments/reviews and make sure you understand them. @su-chang
Thank you very much for your contribution!
I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)
We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.
Please add @lijiarui wechat: _ruirui0914 and send her this pr link. She will invite you into Wechaty Contributor Room
Cheers!
I will merge this PR, but please do read my comments/reviews and make sure you understand them. @su-chang
Thank you very much, got it.
Checklist
References to other Issues or PRs
Related issue: https://github.com/wechaty/wechaty/issues/2250
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments