search

wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet
https://wechaty.github.io/grpc/
Apache License 2.0
26 stars 22 forks source link

Location message #153

Closed su-chang closed 2 years ago

su-chang commented 2 years ago

Checklist

References to other Issues or PRs

Related issue: https://github.com/wechaty/wechaty/issues/2250

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

huan commented 2 years ago

I have noticed that we have a design which needs to be improved:

Please feel free to add the improvements to this PR to refactoring them, and I will work on it later as well.

Thank you very much.

su-chang commented 2 years ago

@huan ping

huan commented 2 years ago

@su-chang Thanks for the improvements!

Sorry for the late reply because we are also considering to use the optional from the latest version of proto3, which is the best practice and will replace the google.protobuf.StringValue.

If not using optional would add complexity or ambiguity, then use optional primitive fields. Wrapper types must not be used going forward. — Optional Primitive Fields

I will take time to merge this PR this week, thank you very much for your patience.

huan commented 2 years ago

CI Green!

huan commented 2 years ago

I will merge this PR, but please do read my comments/reviews and make sure you understand them. @su-chang

huan commented 2 years ago

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: _ruirui0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

su-chang commented 2 years ago

I will merge this PR, but please do read my comments/reviews and make sure you understand them. @su-chang

Thank you very much, got it.