Closed huan closed 2 years ago
According to the current protobuf buffer definition:
https://github.com/wechaty/grpc/blob/31b86b9633c5b2d3d2bdb6eef6687b0c5032751e/proto/wechaty/puppet/message.proto#L159-L162
And our Puppet Service implementation:
https://github.com/wechaty/wechaty-puppet-service/blob/cef48ca9a1fb50e9ab471ed4289d8ac353018327/src/client/puppet-service.ts#L922
We are using a JSON.stringify on our Puppet Payload with the gRPC service, which is not a best practice I believe.
JSON.stringify
Should re-design it when at the same time when we are merging the Location design.
Location
See:
Implemented by #153
@su-chang Appreciate your great work!
According to the current protobuf buffer definition:
https://github.com/wechaty/grpc/blob/31b86b9633c5b2d3d2bdb6eef6687b0c5032751e/proto/wechaty/puppet/message.proto#L159-L162
And our Puppet Service implementation:
https://github.com/wechaty/wechaty-puppet-service/blob/cef48ca9a1fb50e9ab471ed4289d8ac353018327/src/client/puppet-service.ts#L922
We are using a
JSON.stringify
on our Puppet Payload with the gRPC service, which is not a best practice I believe.Should re-design it when at the same time when we are merging the
Location
design.See:
153