Add Untracked files - Githubissues

wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet

https://wechaty.github.io/grpc/

Apache License 2.0

26 stars 22 forks source link

Add Untracked files #160

Closed dchaofei closed 2 years ago

dchaofei commented 2 years ago

Checklist

[ ] Commit Messages follow the Conventional Commits pattern
- A feature commit message is prefixed "feat:"
- A bugfix commit message is prefixed "fix:"
[ ] Tests for the changes have been added
[ ] CI has been passed. (GitHub actions all turns green)
[ ] CLA has been signed

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

huan commented 2 years ago

I have thought about this situation at the beginning of creating this action:

If we adding new files to our wechaty/grpc and at the same time they need to be deployed to the go-grpc repo, then the existing CI script will not add new files.

I did not add git add . because I think we should manually maintain the new files.

However, to use git add . is ok for me, so let's merge this PR and see if it has any cons.

huan commented 2 years ago

It seems that you need to bump the version so that the deploy script can publish to a new version tag.