wechaty / grpc

gRPC Service & Protocol Buffers for Wechaty Puppet
https://wechaty.github.io/grpc/
Apache License 2.0
26 stars 22 forks source link

Feat handle #173

Closed hcfw007 closed 2 years ago

hcfw007 commented 2 years ago

Checklist

References to other Issues or PRs

https://github.com/wechaty/puppet/issues/181

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

add handle related feature mentioned in https://github.com/wechaty/puppet/issues/181

Other comments

It's my first time editing a grpc project, please feel free to tell me what goes wrong.

hcfw007 commented 2 years ago

It seems shopt -s globstar cannot be run by default mac bash and brew install fails inside the wall. I'll try to build in Ubuntu when I get home.

hcfw007 commented 2 years ago

@huan Go and python build check failed since 1.0.1, so it seems it's not me breaking it... Can you check this and see if this can be merged? Then we can start working on puppet-service.

huan commented 2 years ago

Yes, you can just focus on the node js part of it

hcfw007 commented 2 years ago

Yes, you can just focus on the node js part of it

Cool. I think the node part is OK now.

huan commented 2 years ago

Thanks for the information, I will take a look at it later.

hcfw007 commented 2 years ago

Any progress? I hate to bother you this often, but the changes to puppet-service rely on this PR.

huan commented 2 years ago

Thanks for the note. I will take time for working on it tonight, and let know you the result then.

hcfw007 commented 2 years ago

@huan ping

huan commented 2 years ago

Will try my best to look at it tonight.

I have been stucked with the CQRS typing staffs last weekend, hopefully it can be finalized this afternoon.

hcfw007 commented 2 years ago

@huan ping

hcfw007 commented 2 years ago

Thanks for your explanation on grpc field naming. Your commits look good.

huan commented 2 years ago

Should be published as v1.3