Closed hcfw007 closed 2 years ago
It seems shopt -s globstar cannot be run by default mac bash and brew install fails inside the wall. I'll try to build in Ubuntu when I get home.
@huan Go and python build check failed since 1.0.1, so it seems it's not me breaking it... Can you check this and see if this can be merged? Then we can start working on puppet-service.
Yes, you can just focus on the node js part of it
Yes, you can just focus on the node js part of it
Cool. I think the node part is OK now.
Thanks for the information, I will take a look at it later.
Any progress? I hate to bother you this often, but the changes to puppet-service rely on this PR.
Thanks for the note. I will take time for working on it tonight, and let know you the result then.
@huan ping
Will try my best to look at it tonight.
I have been stucked with the CQRS typing staffs last weekend, hopefully it can be finalized this afternoon.
@huan ping
Thanks for your explanation on grpc field naming. Your commits look good.
Should be published as v1.3
Checklist
References to other Issues or PRs
https://github.com/wechaty/puppet/issues/181
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
add handle related feature mentioned in https://github.com/wechaty/puppet/issues/181
Other comments
It's my first time editing a grpc project, please feel free to tell me what goes wrong.