Closed hcfw007 closed 1 year ago
The above code is two functions actually (overloaded):
conversationReadMark (conversationId: string) : Promise<boolean>
conversationReadMark (conversationId: string, hasRead: boolean) : Promise<void>
The first is the getter, and the second is the setter.
I forget how we deal with the similar case before, can you help us to link 1-2 examples before?
The above code is two functions actually (overloaded):
conversationReadMark (conversationId: string) : Promise<boolean> conversationReadMark (conversationId: string, hasRead: boolean) : Promise<void>
The first is the getter, and the second is the setter.
I forget how we deal with the similar case before, can you help us to link 1-2 examples before?
This will work because all fields in proto3 are optional.
However it is not necessary for most Conatc and Room methods to be both setter and getter because we usually get them from contact / room payload. (This ia a different problem)
Great news! We can remote lots of DEPRECATED definitions in our gRPC protocol because comments said DEPRECATED, will be removed after Dec 31, 2022
!
@huan this PR is ready to be reviewed
I have dealed with this build error in the forked version before. I'll open another PR to fix it. (That as I recalled is due to some version issue)
Thanks! Then let's merge the fix CI one before merging this one.
支持会话已读功能 https://github.com/wechaty/grpc/issues/189